Christoph Feck
2010-04-11 20:15:27 UTC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3566/
-----------------------------------------------------------
Review request for Gwenview, kdelibs and usability.
Summary
-------
Add an "alphaChannelEnabled" property to KColorDialog to support QColorDialog::ShowAlphaChannel.
Requires the patch from http://reviewboard.kde.org/r/3565 to show the alpha gradient.
Please comment on:
* name/description of newly added methods in KColorDialog
* visible "Alpha" label ("Opacity"?)
* placement of widgets (yes, Alpha label should be aligned to RGB labels, but how?)
Diffs
-----
/trunk/KDE/kdebase/workspace/qguiplatformplugin_kde/qguiplatformplugin_kde.cpp 1113711
/trunk/KDE/kdelibs/kdeui/colors/kcolordialog.h 1113786
/trunk/KDE/kdelibs/kdeui/colors/kcolordialog.cpp 1113786
Diff: http://reviewboard.kde.org/r/3566/diff
Testing
-------
I used this to test integration with QColorDialog:
#include <QtGui/QApplication>
#include <QtGui/QColorDialog>
#include <QtCore/QDebug>
int main(int argc, char *argv[])
{
QApplication app(argc, argv);
QColor color = QColorDialog::getColor(QColor(255, 0, 0, 100), 0, "Select ARGB Color",
QColorDialog::ShowAlphaChannel);
qDebug() << color;
}
Screenshots
-----------
KColorDialog with enabled AlphaChannel
http://reviewboard.kde.org/r/3566/s/354/
Thanks,
Christoph
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3566/
-----------------------------------------------------------
Review request for Gwenview, kdelibs and usability.
Summary
-------
Add an "alphaChannelEnabled" property to KColorDialog to support QColorDialog::ShowAlphaChannel.
Requires the patch from http://reviewboard.kde.org/r/3565 to show the alpha gradient.
Please comment on:
* name/description of newly added methods in KColorDialog
* visible "Alpha" label ("Opacity"?)
* placement of widgets (yes, Alpha label should be aligned to RGB labels, but how?)
Diffs
-----
/trunk/KDE/kdebase/workspace/qguiplatformplugin_kde/qguiplatformplugin_kde.cpp 1113711
/trunk/KDE/kdelibs/kdeui/colors/kcolordialog.h 1113786
/trunk/KDE/kdelibs/kdeui/colors/kcolordialog.cpp 1113786
Diff: http://reviewboard.kde.org/r/3566/diff
Testing
-------
I used this to test integration with QColorDialog:
#include <QtGui/QApplication>
#include <QtGui/QColorDialog>
#include <QtCore/QDebug>
int main(int argc, char *argv[])
{
QApplication app(argc, argv);
QColor color = QColorDialog::getColor(QColor(255, 0, 0, 100), 0, "Select ARGB Color",
QColorDialog::ShowAlphaChannel);
qDebug() << color;
}
Screenshots
-----------
KColorDialog with enabled AlphaChannel
http://reviewboard.kde.org/r/3566/s/354/
Thanks,
Christoph